Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracker offset trim function (butttons) behave in the opposite direction to configurator pan offset #122

Open
AlexC176 opened this issue Jun 1, 2022 · 0 comments

Comments

@AlexC176
Copy link

AlexC176 commented Jun 1, 2022

One thing I have noticed is that tracker offset trim (buttons) works in the reverse direction to the pan offset setting in the configurator. For example config offset=-15 with offset trim=-15 negates to a zero offset. Looks like the C code does { offset - offset trim } versus { offset + offset trim }. Version - SPRACINGF3 RC1-11.1.0.

File main.c
int16_t getOffset(int16_t offset_master,int8_t offset_trim){
return offset_master - (int16_t)offset_trim;
}

I think this should be
int16_t getOffset(int16_t offset_master,int8_t offset_trim){
return offset_master + (int16_t)offset_trim;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant