From 498467887d40accff609c4f31a5bc7bb101d57b6 Mon Sep 17 00:00:00 2001 From: C Freeman Date: Thu, 21 Mar 2024 03:16:45 +0800 Subject: [PATCH 1/3] TC-IDM-10.4: Remove OTA PICS from check (#32510) * TC-IDM-10.4: Remove OTA PICS from check The PICS XML files do not contain andy PICS for OTA clusters so we can't check them. This is a known issue with the test plans, but we are where we are. * Restyled by autopep8 --------- Co-authored-by: Restyled.io --- src/python_testing/TC_pics_checker.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/python_testing/TC_pics_checker.py b/src/python_testing/TC_pics_checker.py index ad7939df345324..87107196916cd3 100644 --- a/src/python_testing/TC_pics_checker.py +++ b/src/python_testing/TC_pics_checker.py @@ -122,6 +122,11 @@ def test_TC_IDM_10_4(self): checkable_clusters = {cluster_id: cluster for cluster_id, cluster in Clusters.ClusterObjects.ALL_CLUSTERS.items( ) if cluster_id in self.xml_clusters and self.xml_clusters[cluster_id].pics is not None} + # TODO: consider what we want to do with the OTA clusters. They do not currently have PICS codes. + ota_ids = [Clusters.OtaSoftwareUpdateProvider.id, Clusters.OtaSoftwareUpdateRequestor.id] + checkable_clusters = {cluster_id: cluster for cluster_id, + cluster in checkable_clusters.items() if cluster_id not in ota_ids} + self.step(2) for cluster_id, cluster in checkable_clusters.items(): # Ensure the PICS.S code is correctly marked From bc96cb6336d1b9a5278e287fb43b35e0bbf5bcda Mon Sep 17 00:00:00 2001 From: Andrei Litvin Date: Wed, 20 Mar 2024 16:01:54 -0400 Subject: [PATCH 2/3] Switch GITHUB_TOKEN to BLOAT_REPORT since we seem to get 403 when downloading artifacts (#32654) --- .github/workflows/bloat_check.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/bloat_check.yaml b/.github/workflows/bloat_check.yaml index ef06507924cd01..8d9a94b79b974d 100644 --- a/.github/workflows/bloat_check.yaml +++ b/.github/workflows/bloat_check.yaml @@ -49,4 +49,4 @@ jobs: --github-limit-artifacts 500 \ --github-limit-comments 20 \ --github-repository project-chip/connectedhomeip \ - --github-api-token "${{ secrets.GITHUB_TOKEN }}" + --github-api-token "${{ secrets.BLOAT_REPORT }}" From b6f8e4f5161618497de9e10ccda438b326aeedb2 Mon Sep 17 00:00:00 2001 From: Andrei Litvin Date: Wed, 20 Mar 2024 16:04:26 -0400 Subject: [PATCH 3/3] Allow manual bloat check for testing purposes, to not wait 5 minutes to check PAT (#32655) --- .github/workflows/bloat_check.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/bloat_check.yaml b/.github/workflows/bloat_check.yaml index 8d9a94b79b974d..7b503b865081c9 100644 --- a/.github/workflows/bloat_check.yaml +++ b/.github/workflows/bloat_check.yaml @@ -14,6 +14,7 @@ name: Bloat Check on: + workflow_dispatch: schedule: - cron: "*/5 * * * *"