Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top-level README.md instructs use of wrong version of CMake #2037

Closed
IJeffray opened this issue Nov 13, 2024 · 7 comments
Closed

Top-level README.md instructs use of wrong version of CMake #2037

IJeffray opened this issue Nov 13, 2024 · 7 comments
Labels
Milestone

Comments

@IJeffray
Copy link

In current master, cmake/generic_board.cmake uses a POP_FRONT command which only exists in CMake >= 3.15
But the README.md has examples showing cmake_minimum_required(VERSION 3.13)
This leads to significant confusion when the build just spins with the repeated error "list does not recognize sub-command POP_FRON"

CMake 3.13 is the latest in Debian 10, which is admittedly old in the tooth now, but no amount of "apt upgrade" will resolve it.

But there's little point in having a 'minimum required' version line with demonstrably the wrong version in it.
Correcting this would mean that a suitable sane error is thown... "CMake 3.15 or higher is required. You are running version 3.13.4"

@peterharperuk peterharperuk added this to the 2.1.0 milestone Nov 13, 2024
@lurch lurch added the build label Nov 13, 2024
@lurch
Copy link
Contributor

lurch commented Nov 13, 2024

See the discussion in #1879

@lurch
Copy link
Contributor

lurch commented Nov 13, 2024

@IJeffray Are you using the master or develop branch of pico-sdk?

@IJeffray
Copy link
Author

@lurch It's the same on both

@lurch
Copy link
Contributor

lurch commented Nov 13, 2024

@IJeffray Hmmm, #1879 has been merged into the develop branch, so if you're using that branch you should get an error message from CMake, telling you that you need a newer version.

BTW, I assume you're aware that Debian 10 has already reached end of LTS support on 30th June 2024?

@IJeffray
Copy link
Author

@lurch Yeah, I'm aware Debian 10's considered old hat, but it still doesn't really change the underlying issue that things are out of sync.
Sorry I somehow didn't see #1879 before reporting this.
https://github.com/raspberrypi/pico-sdk/tree/develop still shows 3.13 in the README.md though - so whatever was changed for #1879 didn't change that.

@lurch
Copy link
Contributor

lurch commented Nov 13, 2024

https://github.com/raspberrypi/pico-sdk/tree/develop still shows 3.13 in the README.md though - so whatever was changed for #1879 didn't change that.

Yes, as discussed in #1879 the "top-level" CMake files only need CMake 3.13, so that's why the README.md says that too. You might be using a configuration which means that your particular build doesn't need cmake/generic_board.cmake, in which case CMake 3.13 would still be sufficient.

@IJeffray
Copy link
Author

I see. Confusing, but also makes sense I guess. Sorry for wasting time as it's already fixed for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants