Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit cell not in sync with electron density #18

Open
olabe123 opened this issue Jun 1, 2020 · 7 comments
Open

Unit cell not in sync with electron density #18

olabe123 opened this issue Jun 1, 2020 · 7 comments

Comments

@olabe123
Copy link
Contributor

olabe123 commented Jun 1, 2020

When including the unit cell visualization during the visualization of the electron density, the unit cell is displaced compared to the electron density.

@rartino
Copy link
Owner

rartino commented Jun 1, 2020

Do you know if this is always the case? Or just for certain inputs? Might help to track down the issue.

@olabe123
Copy link
Contributor Author

olabe123 commented Jun 1, 2020

I'm not sure. It didn't work for these two HDF5-files at least.

OneDrive_1_2020-06-01.zip

rartino pushed a commit that referenced this issue Jun 5, 2020
@jjeessppeer
Copy link
Collaborator

jjeessppeer commented Jun 11, 2020

I had a similar problem working on this 2019. Something goes wrong with the origin coordinates for atom positions with some HDF5 files so that they get offset. The problem only arised on some HDF5 files.

This could be fixed by disabling the fullMesh property for the StructureMesh processor.
This was originally set in UnitcellNetworkHandler.py.

The problem with disabling fullMesh was that the HDF5 files that worked previously now were offset incorrectly, some files seemed to work with it enabled and some with it disabled. Also the sphere radius cannot be adjusted individually with this property disabled.

I was never sure where this problem originated from. I mainly suspected a bug in the StructureMesh-processor caused it, but it could also be the parser or some VASP setting.

@rartino
Copy link
Owner

rartino commented Jun 11, 2020

@petersteneteg Just a thought: do you know if there is anything with the StructureMesh processor in Inviwo that is easy to miss with regards to the global offset of the coordinates, and which is affected by the 'fullMesh' property?

@jjeessppeer
Copy link
Collaborator

jjeessppeer commented Jun 11, 2020

The StructureMesh processor is part of the ENVISIoN project. It is a part of the crystalvisualization module and is not native to Inviwo.

@rartino
Copy link
Owner

rartino commented Jun 15, 2020

@jjeessppeer Thanks for the clarification; Oh, I see, so it is on our side. The code for that module really isn't so long, so this seems something we should be able to figure out.

I wrote an email to you today on your student email on another rather urgent matter related to ENVISIoN. (Let me know if you no longer use your student email)

@petersteneteg
Copy link

Let me know if I can help out somehow

didax423 pushed a commit to adamskor/ENVISIoN that referenced this issue May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants