adding telemetry #1692
Open
adding telemetry #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msarahan
added
feature request
msarahan
force-pushed
the
add-telemetry
branch
from
7d52daa
to
2b4f54b
Compare
msarahan
force-pushed
the
add-telemetry
branch
from
953f9b8
to
6e97890
Compare
msarahan
force-pushed
the
add-telemetry
branch
from
8a76653
to
7a6f605
Compare
msarahan
force-pushed
the
add-telemetry
branch
4 times, most recently
from
0674d3e
to
4caf981
Compare
msarahan
force-pushed
the
add-telemetry
branch
2 times, most recently
from
8410ebb
to
8d5473a
Compare
ajschmidt8
reviewed
Oct 30, 2024
bdice
reviewed
Nov 4, 2024
| ref: ${{env.SHARED_ACTIONS_REF}} | ||
| path: ./shared-actions | ||
| - id: traceparent | ||
| uses: ./shared-actions/telemetry-traceparent |
There was a problem hiding this comment.
Must we clone this repository? Can we not use a "shared action" as usual?
Something like uses: rapidsai/shared-actions/...@main?
There was a problem hiding this comment.
Yes, we must clone it. There's an explanation for this change at https://github.com/rapidsai/shared-actions. TL;DR - this is the only way to allow shared actions to depend on other shared actions.
Co-authored-by: Bradley Dice <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
close #1691
Checklist