Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rmm::prefetch fault tolerant #1648

Open
bdice opened this issue Aug 15, 2024 · 0 comments · May be fixed by #1649
Open

Make rmm::prefetch fault tolerant #1648

bdice opened this issue Aug 15, 2024 · 0 comments · May be fixed by #1649
Assignees
Labels
cpp Pertains to C++ code feature request New feature or request Python Related to RMM Python API

Comments

@bdice
Copy link
Contributor

bdice commented Aug 15, 2024

Following up from rapidsai/cudf#16551 (comment)

Two problems:

  • Currently RMM does not document the requirement that a prefetch_resource_adaptor must wrap a managed memory resource.
  • Additionally, on systems where managed memory is not supported, a cudaErrorInvalidDevice occurs.

We should make prefetching a transparent fault-tolerant API, with no hard errors. This makes it easier to use prefetching as a "hint" in an application without having to conditionally check for managed memory support from the current memory resource before calling the prefetch API. In cuDF, for instance, we would like to enable prefetching as a performance optimization in many locations -- and do nothing if the memory resource isn't compatible.

@bdice bdice self-assigned this Aug 15, 2024
@bdice bdice linked a pull request Aug 15, 2024 that will close this issue
3 tasks
@harrism harrism added feature request New feature or request Python Related to RMM Python API cpp Pertains to C++ code labels Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp Pertains to C++ code feature request New feature or request Python Related to RMM Python API
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants