Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Build and test RMM C++ Debug in CI #1591

Open
harrism opened this issue Jun 25, 2024 · 0 comments
Open

[FEA] Build and test RMM C++ Debug in CI #1591

harrism opened this issue Jun 25, 2024 · 0 comments
Labels
ci cpp Pertains to C++ code feature request New feature or request

Comments

@harrism
Copy link
Member

harrism commented Jun 25, 2024

Is your feature request related to a problem? Please describe.
Yesterday I was debugging some new code so I did a debug build of RMM and its gtests, and found 3 test fails.

  1. A legitimate UB bug.
  2. A legitimate test failure due to an incorrect expectation for an assertion message
  3. A legitimate test failure due to an assert. This should either be skipped in debug builds or turned into a death test.

Triaging these failures to make sure they weren't related to the change I'm working on cost precious time. Submitting issues and PRs to fix them cost more time.

Describe the solution you'd like
Build and test debug build of librmm and gtests in CI.

Notes in approach from @bdice:
Create a “custom job” (same GitHub Action we use for docs and other misc. tasks) and write a bash script that runs the build and test. I would run this on only one configuration, latest CUDA and latest Python on x86-64. Copy-paste the docs job:

docs-build:
Modify it to use ci-wheel instead of ci-conda (should be faster if you can avoid the conda solve). Write a short bash script to build and test in ci/test_debug.sh. Ideally I would use ./build.sh to build but with custom flags.

Describe alternatives you've considered
Run one-off tests. I don't think this is reliable.

Additional context
Add any other context, code examples, or references to existing implementations about the feature request here.

@harrism harrism added feature request New feature or request cpp Pertains to C++ code ci labels Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci cpp Pertains to C++ code feature request New feature or request
Projects
Status: Todo
Development

No branches or pull requests

1 participant