Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of/eliminate xfails in nx-cugraph tests #31

Open
rlratzel opened this issue Nov 18, 2024 · 1 comment
Open

Reduce number of/eliminate xfails in nx-cugraph tests #31

rlratzel opened this issue Nov 18, 2024 · 1 comment
Assignees

Comments

@rlratzel
Copy link
Contributor

As part of paying down tech debt, there are a number of NetworkX tests that will fail if run using nx-cugraph. These are tests that represent differences between implementations that don't need to prevent users from using nx-cugraph (they're mainly corner cases, such as differences in randomly-selected values for example), but we should still try to reduce these, with the ultimate goal being running the NetworkX tests with nx-cugraph without special cases to dynamically add xfails.

Removing the xfails will involve a combination of updating nx-cugraph and changing the NetworkX tests to be more accommodating of other implementations.

@eriknw
Copy link
Contributor

eriknw commented Nov 18, 2024

I'm gathering some notes here.

xfail:

We should also look at where we set @networkx_algorithm(is_different=True):

  • betweenness_centrality with k can be updated to use the same initial nodes as networkx. This requires updating PLC to acceps a list of nodes instead of a random state seed.

Other technical may be found by git grepping e.g. TODO, FIXME, PERF, DRY (but mostly TODO). Also, functions that define can_run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants