From ef83eb4eaaca1f71c66404022376dff3a6840036 Mon Sep 17 00:00:00 2001 From: James Lamb Date: Tue, 7 May 2024 12:03:40 -0500 Subject: [PATCH] remove 'tomli' dependency (#1338) Proposes removing this project's build-time dependency on `tomli`. It appears to no longer be necessary. ```shell git grep tomli ``` ## Notes for Reviewers I originally noticed something similar in `ucx-py` (https://github.com/rapidsai/ucx-py/pull/1042), then went searching for similar cases across RAPIDS. I'm not sure why this project has a dependency on `tomli`, but I suspect it was related to the use of `versioneer` in this project's history. Reference: https://github.com/python-versioneer/python-versioneer/issues/338#issuecomment-1381170813 This project doesn't use `versioneer` any more (#1204). I strongly suspect that the dependency on `tomli` can be removed. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - https://github.com/jakirkham - Ray Douglass (https://github.com/raydouglass) URL: https://github.com/rapidsai/dask-cuda/pull/1338 --- conda/recipes/dask-cuda/meta.yaml | 1 - dependencies.yaml | 3 --- pyproject.toml | 1 - 3 files changed, 5 deletions(-) diff --git a/conda/recipes/dask-cuda/meta.yaml b/conda/recipes/dask-cuda/meta.yaml index c194d117b..357e6dede 100644 --- a/conda/recipes/dask-cuda/meta.yaml +++ b/conda/recipes/dask-cuda/meta.yaml @@ -29,7 +29,6 @@ requirements: host: - python - pip - - tomli run: - python {% for r in data.get("project", {}).get("dependencies", []) %} diff --git a/dependencies.yaml b/dependencies.yaml index 5c42b16f0..20c6ca05e 100644 --- a/dependencies.yaml +++ b/dependencies.yaml @@ -75,9 +75,6 @@ dependencies: - output_types: [conda, requirements, pyproject] packages: - setuptools>=64.0.0 - - output_types: pyproject - packages: - - tomli ; python_version < '3.11' cuda_version: specific: - output_types: conda diff --git a/pyproject.toml b/pyproject.toml index e505e30da..35d485381 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -2,7 +2,6 @@ build-backend = "setuptools.build_meta" requires = [ "setuptools>=64.0.0", - "tomli ; python_version < '3.11'", ] # This list was generated by `rapids-dependency-file-generator`. To make changes, edit dependencies.yaml and run `rapids-dependency-file-generator`. [project]