Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Unify constness usage for bitset filters of ANN #447

Open
lowener opened this issue Nov 6, 2024 · 0 comments
Open

[BUG] Unify constness usage for bitset filters of ANN #447

lowener opened this issue Nov 6, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@lowener
Copy link
Contributor

lowener commented Nov 6, 2024

To unify the use of bitset filters for different ANN, the filter should use constness on its data type.
Currently only Bruteforce is using const filter: https://github.com/rapidsai/cuvs/blob/branch-24.12/cpp/src/neighbors/detail/knn_brute_force.cuh#L738C54-L738C67
The other indexes don't use const filter.

@lowener lowener added the bug Something isn't working label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant