Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] cuvs-bench recipe doesn't have a dependency on cuvs Python, but create_groundtruth requires it. #426

Open
cjnolet opened this issue Oct 25, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@cjnolet
Copy link
Member

cjnolet commented Oct 25, 2024

I think we could get around 2 issues here:

  1. The cuvs-bench-cpu cannot use the gpu to generate ground truth
  2. The cuvs-bench doesn't have a hard dependnecy on cuvs python, even though it assumes it's installed to create_groundtruth.

We should test if cuvs is installed in the python environment, and if not, issue a warning that the ground truth could be much faster if cuvs were installed. Then we should fall back to numpy.

@cjnolet cjnolet added the bug Something isn't working label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

1 participant