Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_geodataframe.py's test_memory_usage is failing due to size mismatch #1352

Open
jakirkham opened this issue Mar 1, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@jakirkham
Copy link
Member

jakirkham commented Mar 1, 2024

As part of the Python 3.11 bringup, we noticed that test_geodataframe.py's test_memory_usage fails

Namely in Python 3.9 and 3.10 it uses 224 bytes, but in Python 3.11 it uses 228 bytes

def test_memory_usage(gs):
assert gs.memory_usage() == 224
host_dataframe = gpd.read_file(
gpd.datasets.get_path("naturalearth_lowres")
)
gpu_dataframe = cuspatial.from_geopandas(host_dataframe)
# The df size is 8kb of cudf rows and 217kb of the geometry column
assert gpu_dataframe.memory_usage().sum() == 224945

Unfortunately in Python these kinds of tests can be pretty flaky as things can change in under-the-hood dependencies (perhaps in Python itself) or do to platform differences, so it might be worth rethinking this test altogether

For now this test is being skipped. Filing this issue to track

This test was originally added in PR ( #604 )

@jakirkham jakirkham added the bug Something isn't working label Mar 1, 2024
rapids-bot bot pushed a commit that referenced this issue Mar 1, 2024
This marks a memory test as `xfail`, which was failing on Python 3.11.

xref: #1352
xref: rapidsai/build-planning#3

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - https://github.com/jakirkham
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #1351
@harrism
Copy link
Member

harrism commented Mar 4, 2024

Seems a bit problematic to have tests that expect exact data sizes for data structures that might change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

2 participants