Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Support for dynamic groupby in cudf-polars #17144

Open
2 of 3 tasks
wence- opened this issue Oct 22, 2024 · 3 comments
Open
2 of 3 tasks

[FEA] Support for dynamic groupby in cudf-polars #17144

wence- opened this issue Oct 22, 2024 · 3 comments
Labels
cudf.polars Issues specific to cudf.polars feature request New feature or request

Comments

@wence-
Copy link
Contributor

wence- commented Oct 22, 2024

Is your feature request related to a problem? Please describe.

Polars supports group_by_dynamic that does (approximately) grouped rolling windows.

We do not currently support this in cudf-polars, what is more, the IR doesn't distinguish between normal groupbys and dynamic groupbys when we get it from polars. Consequently, we only fall back to CPU based on some heuristics, and sometimes just do the wrong thing.

Describe the solution you'd like

@wence- wence- added cudf.polars Issues specific to cudf.polars feature request New feature or request labels Oct 22, 2024
@wence-
Copy link
Contributor Author

wence- commented Oct 22, 2024

Exposure, so we at least can fall back correctly in polars is pola-rs/polars#19385

wence- added a commit to wence-/cudf that referenced this issue Oct 23, 2024
Now that the dynamic groupby options are exposed, we can raise without
heuristics.

Partially addresses rapidsai#17144
wence- added a commit to wence-/cudf that referenced this issue Oct 23, 2024
Now that the dynamic groupby options are exposed, we can raise without
heuristics.

Partially addresses rapidsai#17144
@vyasr
Copy link
Contributor

vyasr commented Oct 28, 2024

@wence- is there urgency to get this actually implemented, or are we OK with fallback for 24.12 (now that pola-rs/polars#19385 is out) while we work on higher priority tasks like inequality joins?

@wence-
Copy link
Contributor Author

wence- commented Oct 30, 2024

I think the implementation can wait a bit. I think it falls under the aegis of rolling window stuff, so needs work related to that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cudf.polars Issues specific to cudf.polars feature request New feature or request
Projects
Status: Todo
Status: In Progress
Development

No branches or pull requests

2 participants