Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Series.count shouldn't be allowing kwargs #14089

Closed
galipremsagar opened this issue Sep 12, 2023 · 0 comments · Fixed by #14106
Closed

[BUG] Series.count shouldn't be allowing kwargs #14089

galipremsagar opened this issue Sep 12, 2023 · 0 comments · Fixed by #14106
Assignees
@galipremsagar
Labels
bug Something isn't working Python Affects Python cuDF API.

Comments

@galipremsagar
Copy link
Contributor

Describe the bug
Allowing kwargs in Series.count is leading other unsupported parameters to silently pass the API call.
Pandas Series.count, doesn't have kwargs. 1.5 has level and 2.0 drops that parameter altogether.
@galipremsagar galipremsagar added bug Something isn't working Python Affects Python cuDF API. labels Sep 12, 2023
@galipremsagar galipremsagar self-assigned this Sep 12, 2023
@galipremsagar galipremsagar mentioned this issue Sep 13, 2023
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this issue Sep 18, 2023
@galipremsagar
Drop kwargs from Series.count (#14106)
5935ef3 
Fixes: #14089 
This PR drops `kwargs` from `Series.count` method signature.

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Matthew Roeschke (https://github.com/mroeschke)
  - Benjamin Zaitlen (https://github.com/quasiben)

URL: #14106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@galipremsagar galipremsagar

Labels
bug Something isn't working Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop kwargs from Series.count galipremsagar/cudf
1 participant
@galipremsagar