Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating cuCIM's build/CI infra to use scikit-build, rapids-cmake, whl builds, etc. #305

Closed
jakirkham opened this issue Jun 6, 2022 · 6 comments
Assignees
Labels
improvement Improves an existing functionality

Comments

@jakirkham
Copy link
Member

Other RAPIDS libraries have been moving to scikit-build for Python packages, this integrates nicely with CMake and can simplify the build process (as well as making other package builds like wheels easier). Would be good to investigate doing the same for cuCIM

cc @vyasr (who has some experience here)

@vyasr
Copy link
Contributor

vyasr commented Jun 7, 2022

If cuCIM moves forward with this transition I would recommend also making use of rapids-cmake, which has a lot of the helper functions I wrote to simplify the process.

@jakirkham
Copy link
Member Author

This PR ( rapidsai/cudf#10919 ) making this change to cuDF could serve as a good example

@gigony gigony self-assigned this Jun 14, 2022
@jakirkham jakirkham added the improvement Improves an existing functionality label Aug 15, 2022
@jakirkham
Copy link
Member Author

Maybe a simpler example case is this KvikIO PR ( rapidsai/kvikio#32 )

@caryr35 caryr35 added this to cucim Nov 15, 2022
@bdice
Copy link
Contributor

bdice commented Aug 8, 2023

@jakirkham requested that I share additional info about wheel builds here:

cuCIM builds wheels in a different way than most of RAPIDS. The guide for RAPIDS wheel builds says to remove versioneer and migrate to pyproject.toml. If migrating to a build system that is more similar to the rest of RAPIDS, cuCIM should remove its usage of versioneer. Another part of this migration would be to move from the current setup.py to pyproject.toml.

@bdice
Copy link
Contributor

bdice commented Aug 8, 2023

@jakirkham jakirkham changed the title Use scikit-build Updating cuCIM's build/CI infra to use scikit-build, rapids-cmake, whl builds, etc. Aug 8, 2023
@jakirkham
Copy link
Member Author

A good chunk of this was done in recent PRs:

Going to close this out. Anything else can be raised in more focused issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality
Projects
Status: Done
Development

No branches or pull requests

4 participants