Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: <Button/> #40

Open
raphamorim opened this issue Oct 25, 2019 · 5 comments
Open

Components: <Button/> #40

raphamorim opened this issue Oct 25, 2019 · 5 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@raphamorim
Copy link
Owner

raphamorim commented Oct 25, 2019

Reference: https://facebook.github.io/react-native/docs/button

Description: Implement an initial version of Button component on React Ape renderer using Canvas.

AC: Consider using it on devices like TV and portable games.

@raphamorim raphamorim added enhancement New feature or request help wanted Extra attention is needed labels Oct 25, 2019
@raphamorim raphamorim added this to the 0.1.0 milestone Oct 25, 2019
@raphamorim raphamorim changed the title Components: <Button/> Components: <Button/> Oct 25, 2019
@hayanisaid
Copy link
Contributor

@raphamorim I can take a look at this issue!

@raphamorim
Copy link
Owner Author

Sounds good, thank you @hayanisaid 👍
(Just a FYI: I am working in parallel in the navigation API)

@hayanisaid
Copy link
Contributor

hayanisaid commented Jun 17, 2022

@raphamorim I have some questions about the Button component:

  • Should it add onPress, onClick, onFocus, onBluras props all together, or just enable an event based on the platform, but we don't have the Platform module yet.
  • I'm trying to make the button have an auto-layout, but I need to rely on the parentLayout {width,height} to got that done, do you know how this can be implemented? since the Flexbox is not implemented yet?

@hayanisaid
Copy link
Contributor

Also, should I create another PR for the EventsHandling?

@raphamorim
Copy link
Owner Author

I think for now let's start with small changes (will be better to review later), so would recommend start the onClick and be layout-dummy, for example: maybe render as similar behaviour as a Text, reading View parentLayout and rendering anywhere inside there

@raphamorim raphamorim moved this from Todo to In Progress in React Ape 1.0.0 (stable) Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
No open projects
Status: In Progress
Development

No branches or pull requests

2 participants