Skip to content
This repository has been archived by the owner on Mar 26, 2024. It is now read-only.

Migrate tests structure based on phanthomjs to other runner option #73

Open
raphamorim opened this issue Mar 13, 2018 · 5 comments
Open

Comments

@raphamorim
Copy link
Owner

Currently Phantomjs is no longer maintained. I was wondering if make sense to move to Puppeteer or other option to run origamijs tests.

@alejandronanez
Copy link

Puppeteer would be a good choice. Do you have any boilerplate or preference on how the tests should be structured?

@raphamorim
Copy link
Owner Author

@alejandronanez no preferences at all, I’m totally opened to suggestions

@alejandronanez
Copy link

This sounds like a super interesting task; I can take a look at it.

Disclaimer: I've never done any serious work with PhantomJS or Puppeteer.

@raphamorim
Copy link
Owner Author

No problem @alejandronanez.
If you want to you can start work from this PR https://github.com/raphamorim/origami.js/pull/70/files (just to updating little things)

@alejandronanez
Copy link

Cool, I'll take a look. Thanks @raphamorim

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants