Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parameter overriding #46

Open
vineetbansal opened this issue Sep 20, 2024 · 0 comments
Open

parameter overriding #46

vineetbansal opened this issue Sep 20, 2024 · 0 comments

Comments

@vineetbansal
Copy link
Contributor

I just noticed that the dictionary log ends up overwriting the parameter log, which is problematic because later in the code I see more if log: checks, which were presumably meant to check the parameter and not the dictionary (which will never evaluate to False as long as it has any keys).

log = {'err': [], 'loss': []}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant