Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c++0x and vmkit #5

Open
jean-dao opened this issue Mar 31, 2012 · 6 comments
Open

c++0x and vmkit #5

jean-dao opened this issue Mar 31, 2012 · 6 comments

Comments

@jean-dao
Copy link
Collaborator

All vmkit source code does not use c++0x standard unlike Z3. I don't think we can manage to keep both as is and fix it automagically in the Makefile (Please prove me wrong!).

2 choices: we modify all of our headers or all of vmkit headers (yeah sure) to comply with only one standard.

@gaelthomas
Copy link
Collaborator

I don't understand where is the problem? Z3's makefiles and vmkit's
makefile are totally unrelated... So you can add your prefered --std=
in Z3's makefiles?

Gaël

2012/3/31 jean-dao
[email protected]:

All vmkit source code does not use c++0x standard unlike Z3. I don't think we can manage to keep both as is and fix it automagically in the Makefile (Please prove me wrong!).

2 choices: we modify all of our headers or all of vmkit headers (yeah sure) to comply with only one standard.


Reply to this email directly or view it on GitHub:
https://github.com/raph-amiard/Z3/issues/5


Gaël Thomas, Associate Professor,
University of Pierre and Marie Curie
Boite courrier 169, 217 - 26-00, REGAL Team, INRIA/LIP6,
4, place Jussieu, 75252 Paris Cedex 05, France
Web: http://pagesperso-systeme.lip6.fr/Gael.Thomas/

Phone (mob): +33 6 10 39 31 17           Fax : +33 1 44 27 70 00

@jean-dao
Copy link
Collaborator Author

jean-dao commented Apr 1, 2012

Well in our code we have to include some vmkit headers which will be compiled with our makefile, so with our standard. I didn't manage to keep the c++0x standard and not having errors in vmkit headers.

But I am struggling with the makefile (trying to merge toyvm and Z3) so I may be doing something wrong...

@raph-amiard
Copy link
Owner

I don't understand either. Obviously Z3 is gonna include some of vmkit's headers, but that shouldn't be a problem since C++11 is compatible with C++98. That's a certainty. Are you sure the errors are related to the fact that we use the C++11 std ? If yes, could you post an example ?

@raph-amiard
Copy link
Owner

If this is really a problem though, it shouldn't be too hard to modify just the headers to be C++98 compliant. But i smell something fishy here :)

@jean-dao
Copy link
Collaborator Author

jean-dao commented Apr 1, 2012

Well I'm not sure of anything since I was playing around with the makefile to make it work. Anyway I ended modifying some of our headers (nothing much really) to make them C++98 compliant.

In fact I think this is a Makefile issue.

@gaelthomas
Copy link
Collaborator

Ok, I understand the pbm :)

You have two solutions. Either you can modify your files to be
compliant with the standard used in vmkit, nor you can just define the
standard before including vmkit's header. But I think that the second
solution will not work...

Gaël

2012/4/1 jean-dao
[email protected]:

Well I'm not sure of anything since I was playing around with the makefile to make it work. Anyway I ended modifying some of our headers (nothing much really) to make them C++98 compliant.

In fact I think this is a Makefile issue.


Reply to this email directly or view it on GitHub:
https://github.com/raph-amiard/Z3/issues/5#issuecomment-4865767


Gaël Thomas, Associate Professor,
University of Pierre and Marie Curie
Boite courrier 169, 217 - 26-00, REGAL Team, INRIA/LIP6,
4, place Jussieu, 75252 Paris Cedex 05, France
Web: http://pagesperso-systeme.lip6.fr/Gael.Thomas/

Phone (mob): +33 6 10 39 31 17           Fax : +33 1 44 27 70 00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants