-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
c++0x and vmkit #5
Comments
I don't understand where is the problem? Z3's makefiles and vmkit's Gaël 2012/3/31 jean-dao
Gaël Thomas, Associate Professor, Phone (mob): +33 6 10 39 31 17 Fax : +33 1 44 27 70 00 |
Well in our code we have to include some vmkit headers which will be compiled with our makefile, so with our standard. I didn't manage to keep the c++0x standard and not having errors in vmkit headers. But I am struggling with the makefile (trying to merge toyvm and Z3) so I may be doing something wrong... |
I don't understand either. Obviously Z3 is gonna include some of vmkit's headers, but that shouldn't be a problem since C++11 is compatible with C++98. That's a certainty. Are you sure the errors are related to the fact that we use the C++11 std ? If yes, could you post an example ? |
If this is really a problem though, it shouldn't be too hard to modify just the headers to be C++98 compliant. But i smell something fishy here :) |
Well I'm not sure of anything since I was playing around with the makefile to make it work. Anyway I ended modifying some of our headers (nothing much really) to make them C++98 compliant. In fact I think this is a Makefile issue. |
Ok, I understand the pbm :) You have two solutions. Either you can modify your files to be Gaël 2012/4/1 jean-dao
Gaël Thomas, Associate Professor, Phone (mob): +33 6 10 39 31 17 Fax : +33 1 44 27 70 00 |
All vmkit source code does not use c++0x standard unlike Z3. I don't think we can manage to keep both as is and fix it automagically in the Makefile (Please prove me wrong!).
2 choices: we modify all of our headers or all of vmkit headers (yeah sure) to comply with only one standard.
The text was updated successfully, but these errors were encountered: