Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport v2.10] [SURE-8794] Deploying ClusterGroup from GitRepo results in loop #3118

Closed
rancherbot opened this issue Dec 3, 2024 · 1 comment

Comments

@rancherbot
Copy link
Collaborator

This is a backport issue for #2859, automatically created via GitHub Actions workflow initiated by @p-se

Original issue body:

Deploying a ClusterGroup from a GitRepo which also contains accompanying other GitRepo resources that use those newly created ClusterGroups result in a loop.

This loop triggers ClusterGroups and appends a message to it that endlessly grows, until the limit of etcd is hit. In which case Fleet is supposedly blocked.

The issue can be reproduced by adding this GitRepo resource to the cluster. The issue was reproducible on the latest Fleet development version at the time and did not require a Rancher installation to reproduce. The cluster was prepared using dev/setup-multi-cluster.

@rancherbot rancherbot added JIRA Must shout kind/bug labels Dec 3, 2024
@rancherbot rancherbot added this to the v2.10.1 milestone Dec 3, 2024
@rancherbot rancherbot added this to Fleet Dec 3, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Fleet Dec 3, 2024
@manno manno moved this from 🆕 New to 👀 In review in Fleet Dec 4, 2024
@manno manno moved this from 👀 In review to Needs QA review in Fleet Dec 9, 2024
@mmartin24
Copy link
Collaborator

Verified in Rancher 2.10.1-alpha1with Fleet fleet:105.0.2+up0.11.2-rc.2


Tested using steps on Jira ticket (deploying 01534177-git-registrations branch over repo https://github.com/axeal/fleet-test.git

After 27 mins, a single log appears in the fixed version:
Image

... while logs increased endlessly in in 2.8.5

Image

It looks fixed to me.

@github-project-automation github-project-automation bot moved this from Needs QA review to ✅ Done in Fleet Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants