-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Fleet-Controller to StatefulSet #1837
Comments
We discussed and will try to improve the existing leader election code first.
|
This is going to be moved into leader election when we split the cleanup into a different container https://github.com/raulcabello/fleet/blob/split-cleanup/internal/cmd/controller/cleanup/start.go#L39 |
We're going to fix leader election instead.
|
Our controllers are running in a k8s deployment. We see that work is done outside the leader election if multiple replicas exist or during upgrades. E.g. fleet-controller runs "cleanup" multiple times, controllers start up and create CRDs in parallel, fleet-agent runs multiple registrations.
Leader election is an expensive operation, our default timing is 30s renew, 45s for the lease.
We also see problems with the lock files, client-go > 0.25 (?) will deprecate the current lock resource. The current lease mechanism causes problems with backup and restore. The lead election code lives in wrangler and keeps us from updating client-go.
From the controller-runtime docs:
See:
The text was updated successfully, but these errors were encountered: