Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SignColumn in Neogit #74

Open
windowsrefund opened this issue Oct 28, 2024 · 3 comments
Open

SignColumn in Neogit #74

windowsrefund opened this issue Oct 28, 2024 · 3 comments

Comments

@windowsrefund
Copy link
Contributor

Greets,

Neogit makes use of the sign column to show the status of internal folds.

image

image

When Mellifluous is active, SignColumn is linked to LineNr. Normally, this is great but we can see how it breaks down against the NeogitStatus file type.

By comparison, a look at the same thing via the default Astronvim theme has that area of the tool looking much cleaner.

image

and I see when that theme is active, SignColumn is cleared.

So back to our favorite scheme, Mellifluous, I can't understand why that sign column is behaving like this? Even though it's linked to LineNr, it is behaving in a way where the bg color is highlighting when it should just sit there and remain dark. Of course, the real move here would be to simply ignore it and move on but I'm finding that to be a challenge :)

@ramojus
Copy link
Owner

ramojus commented Oct 29, 2024

Yeah, it doesn't look good, the backgrounds in signcolumn should match. I don't use Neogit, so I'm not really motivated to investigate this. There might be some Neogit highlight group that you could set, or you can clear the SignColumn highlight group.

I think Neogit just sets their own highlight group that by default doesn't respect the background of SignColumn. It might be worth creating an issue there.

@windowsrefund
Copy link
Contributor Author

Turns out things are good when foldcolumn is used rather than signcolumn. I've asked the hard-coded options be removed here

@ramojus
Copy link
Owner

ramojus commented Nov 1, 2024

That is strange
image
image

So it respects the background of foldcolumn, but doesn't respect the background of signcolumn? Or do you use different FoldColumn highlight than default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants