Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance favicon or add ability to override #26

Open
nathan-io opened this issue Jan 15, 2023 · 1 comment
Open

Enhance favicon or add ability to override #26

nathan-io opened this issue Jan 15, 2023 · 1 comment

Comments

@nathan-io
Copy link

Hello, thank you for this package!

I took at a look at the favicon tag, and it seems to be barebones.

I'm curious if it's possible to either exclude that tag (so we can define it ourselves), or, to enhance this package with broader favicon support across a variety devices and display sizes.

See this article goes in depth with some of the options and best practices.

As an example, the https://realfavicongenerator.net/ tool generates output like the following, depending on the user's chosen color settings:

<link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon.png">
<link rel="icon" type="image/png" sizes="32x32" href="/favicon-32x32.png">
<link rel="icon" type="image/png" sizes="16x16" href="/favicon-16x16.png">
<link rel="manifest" href="/site.webmanifest">
<link rel="mask-icon" href="/safari-pinned-tab.svg" color="#5bbad5">
<meta name="msapplication-TileColor" content="#da532c">
<meta name="theme-color" content="#ffffff">
@ralphjsmit
Copy link
Owner

Hey @nathan-io, thanks for the request!

More advanced favicon is something that's on my todo list, because I was indeed aware that this is a sort of blind spot in the package. It won't be in a very short term, but should be somewhere in the coming months. First need to finish a overdue upgrade on one of my premium packages (https://filamentphp.com/plugins/media-library-pro), but this one comes after that.

If you're open to it, you can always create a PR with updated favicon support. Otherwise I'd suggest waiting out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants