Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async methods should support a cancellation token #368

Open
kenkendk opened this issue Oct 24, 2024 · 0 comments
Open

Async methods should support a cancellation token #368

kenkendk opened this issue Oct 24, 2024 · 0 comments

Comments

@kenkendk
Copy link

Describe the feature request or question
The ...Async methods, such as ReadSecretAsync() does not support a CancellationToken so it is not possible for the caller to cancel the request.

Link to the Vault API Docs that support this feature
Not relevant, this is purely a C# convention.

Additional context
See sonar rule here: https://community.sonarsource.com/t/c-asynchronous-methods-should-take-a-cancellationtoken/42190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant