Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread Safety Concern in processSchemeData Method #189

Open
coderabbitai bot opened this issue Sep 23, 2024 · 0 comments
Open

Thread Safety Concern in processSchemeData Method #189

coderabbitai bot opened this issue Sep 23, 2024 · 0 comments
Assignees
@rajadilipkolli

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 23, 2024

In PR #188, there is a thread safety concern in the processSchemeData method of BSEStarMasterDataService.java. The double-checked locking pattern with ReentrantLock may still pose concurrency issues if the mfAmcService.findByCode and mfAmcService.saveMfAmc methods are not thread-safe. Additionally, locking on a single ReentrantLock may become a bottleneck.

Refer to the comment: Discussion

Requested by @rajadilipkolli.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rajadilipkolli rajadilipkolli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rajadilipkolli