when endpoint discovery is not used, adding an endpoint fails

[woodsaj]

No description provided.

[woodsaj]

If endpoint discover is skipped or fails (eg due to not using a hostname) then adding a check fails.
No error is reported back to the user, clicking the "Add" button doesnt do anything.

Looking at the developer tools, the following is sent to /api/v2/endpoints

{"tags":["test"],"name":"foo blah","checks":[{"enabled":true,"frequency":10,"route":{"type":"byIds","config":{"ids":[87,89,949]}},"settings":{"hostname":"grafana.com","timeout":5},"healthSettings":{"num_collectors":2,"steps":3}}]}

The response is:

{"meta":{"code":400,"message":"unknown check type. ","type":"error"},"body":null}

So the issue looks to be due to individual check defaults not being set.
ie, after https://github.com/raintank/worldping-app/blob/master/src/components/endpoint/endpoint_config.js#L471
we need to

this.checks["http"] = defaultCheck("http");
this.checks["https"] = defaultCheck("https");
this.checks["ping"] = defaultCheck("ping");
this.checks["dns"] = defaultCheck("dns");

[luizferreira094]

+1

[luizferreira094]

Having the same issue here,
I'm trying to create an endpoint for monitoring with my internal probe, and i get the same error, when trying to apply the config.
PS: Tried in all configs (Ping, DNS, HTTP and HTTPS)

WorldPing version: 1.2.6
Grafana version: v6.1.3