From 722c99be25d6e41b70a2f9e5e88f742b03225e57 Mon Sep 17 00:00:00 2001
From: Rosa Gutierrez <rosa@37signals.com>
Date: Mon, 30 Oct 2023 17:55:42 +0100
Subject: [PATCH] Add NOT NULL constraints to all job_id columns

---
 db/migrate/20231030164933_make_job_id_not_null.rb |  8 ++++++++
 test/dummy/db/schema.rb                           | 10 +++++-----
 2 files changed, 13 insertions(+), 5 deletions(-)
 create mode 100644 db/migrate/20231030164933_make_job_id_not_null.rb

diff --git a/db/migrate/20231030164933_make_job_id_not_null.rb b/db/migrate/20231030164933_make_job_id_not_null.rb
new file mode 100644
index 00000000..c5e2a5f5
--- /dev/null
+++ b/db/migrate/20231030164933_make_job_id_not_null.rb
@@ -0,0 +1,8 @@
+class MakeJobIdNotNull < ActiveRecord::Migration[7.1]
+  def change
+    change_column :solid_queue_claimed_executions, :job_id, :bigint, null: false
+    change_column :solid_queue_failed_executions, :job_id, :bigint, null: false
+    change_column :solid_queue_ready_executions, :job_id, :bigint, null: false
+    change_column :solid_queue_scheduled_executions, :job_id, :bigint, null: false
+  end
+end
diff --git a/test/dummy/db/schema.rb b/test/dummy/db/schema.rb
index 342809bb..f2880229 100644
--- a/test/dummy/db/schema.rb
+++ b/test/dummy/db/schema.rb
@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema[7.1].define(version: 2023_10_25_165946) do
+ActiveRecord::Schema[7.1].define(version: 2023_10_30_164933) do
   create_table "job_results", charset: "utf8mb4", collation: "utf8mb4_0900_ai_ci", force: :cascade do |t|
     t.string "queue_name"
     t.string "status"
@@ -20,7 +20,7 @@
   end
 
   create_table "solid_queue_claimed_executions", charset: "utf8mb4", collation: "utf8mb4_0900_ai_ci", force: :cascade do |t|
-    t.bigint "job_id"
+    t.bigint "job_id", null: false
     t.bigint "process_id"
     t.datetime "created_at", null: false
     t.index ["job_id"], name: "index_solid_queue_claimed_executions_on_job_id", unique: true
@@ -28,7 +28,7 @@
   end
 
   create_table "solid_queue_failed_executions", charset: "utf8mb4", collation: "utf8mb4_0900_ai_ci", force: :cascade do |t|
-    t.bigint "job_id"
+    t.bigint "job_id", null: false
     t.text "error"
     t.datetime "created_at", null: false
     t.index ["job_id"], name: "index_solid_queue_failed_executions_on_job_id", unique: true
@@ -63,7 +63,7 @@
   end
 
   create_table "solid_queue_ready_executions", charset: "utf8mb4", collation: "utf8mb4_0900_ai_ci", force: :cascade do |t|
-    t.bigint "job_id"
+    t.bigint "job_id", null: false
     t.string "queue_name", null: false
     t.integer "priority", default: 0, null: false
     t.datetime "created_at", null: false
@@ -73,7 +73,7 @@
   end
 
   create_table "solid_queue_scheduled_executions", charset: "utf8mb4", collation: "utf8mb4_0900_ai_ci", force: :cascade do |t|
-    t.bigint "job_id"
+    t.bigint "job_id", null: false
     t.string "queue_name", null: false
     t.integer "priority", default: 0, null: false
     t.datetime "scheduled_at", null: false