Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base_controller_class is always loaded / required, even with lazy loading #234

Open
tight opened this issue Jan 15, 2025 · 0 comments
Open

Comments

@tight
Copy link

tight commented Jan 15, 2025

👋

I noticed that when starting my app in development (with lazy loading), base_controller_class is always loaded (which in turns loads a bunch of files from my app) and I would like to avoid that, since it increases app boot time
There's a specific piece of code to load the base_controller_class here added in this old commit (see comment).
Also, I changed mission_controll-jobs' dummy app in tests to use a specific class and commented the code above, everything still works, tests pass, no loading issue
So, I'm wondering if this piece of code still make sense, and if it can be removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant