-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible to avoid adding Rack::MethodOverride middleware to main app? #207
Comments
Oops, @mintuhouse, sorry about this! Last week I was on-call and couldn't pay a lot of attention to this repo. Is this not an issue anymore? I think adding the middleware so that it only affects Mission Control should be possible, I just haven't looked into it. |
Sorry! Some linear rule at work closed this issue too when we pushed a workaround for this. # config/initializers/mission_control.rb
Rails.application.config.middleware.delete(Rack::MethodOverride)
Rails.application.config.middleware.delete(ActionDispatch::Flash)
MissionControl::Jobs::Engine.config.middleware.use(ActionDispatch::Flash)
MissionControl::Jobs::Engine.config.middleware.use(Rack::MethodOverride) We are unblocked for now |
Ohhh, haha! Thanks for letting me know! I'll do that same change actually 😅 |
In our API only rails app, we use
Rack::RewindableInput::Middleware
for one of the enginesAdding
Rack::MethodOverride
to main app breaks this engineCan we add the middleware just for the
MissionControl::Jobs::Engine
?SO post explains the issue
The text was updated successfully, but these errors were encountered: