Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings and prevent Jbuilder::VERSION constant from being obliterated #574

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix warnings and prevent Jbuilder::VERSION constant from being obliterated #574

wants to merge 5 commits into from

Commits on Sep 18, 2024

  1. Fix warning about routes.rb not existing 

    The controller scaffold generator tries to insert routes but there isn't
a routes file the tmp folder so it prints a warning instead. Prevent the
warning from being printed by using the option to skip routes.
    @pixeltrix
    pixeltrix committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    ee11466 View commit details
    Browse the repository at this point in the history

  2. Use the correct path for the env command

    @pixeltrix
    pixeltrix committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    743838a View commit details
    Browse the repository at this point in the history

  3. Add Rails 7.2 to the Appraisals file

    @pixeltrix
    pixeltrix committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    9aa2531 View commit details
    Browse the repository at this point in the history

  4. Fix method redefinition warning

    @pixeltrix
    pixeltrix committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    9e0540b View commit details
    Browse the repository at this point in the history

  5. Fix constant redefinition warning 

    In e18fe2a the Jbuilder::VERSION constant was introduced but in 9aa3dd9
it was used in the gemspec which changed the loading order so that the
version constant was loaded first. This defined Jbuilder as an Object
subclass rather than the intended BasicObject and when jbuilder/jbuilder
was required it redefined the Jbuilder constant and obliterates the
VERSION constant. This commit ensures that the version constant exists
and the Jbuilder parent class is BasicObject.
    @pixeltrix
    pixeltrix committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    edf849b View commit details
    Browse the repository at this point in the history