Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove multi_json as dependency in favor of std-lib json #210

Open
robsdudeson opened this issue Jan 13, 2024 · 3 comments
Open

Remove multi_json as dependency in favor of std-lib json #210

robsdudeson opened this issue Jan 13, 2024 · 3 comments

Comments

@robsdudeson
Copy link

multi_json is End of Life for over a decade now

we should use the ruby std-lib json instead
robsdudeson added a commit to robsdudeson/activerecord-session_store that referenced this issue Jan 30, 2024
@robsdudeson
fix: Remove multi_json as dependency in favor of std-lib json rails#210
0560e72
@otherguy
Copy link
Contributor

otherguy commented Sep 4, 2024

Also implemented here: #213

@robsdudeson
Copy link
Author

I've moved on from a project where this was a problem. I'm happy to go with your approach, though I'm not a maintainer on this.

@otherguy
Copy link
Contributor

otherguy commented Sep 4, 2024

Yeah, our PRs are identical. I just wanted to cross link it here, in case someone else stumbles upon this issue.

Perhaps @byroot could take a look at merging one of them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@otherguy @robsdudeson