Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on Open Channel Progress #2154

Closed
2 tasks done
christianbrb opened this issue Sep 22, 2020 · 4 comments · Fixed by #2164
Closed
2 tasks done

Feedback on Open Channel Progress #2154

christianbrb opened this issue Sep 22, 2020 · 4 comments · Fixed by #2164

Comments

@christianbrb
Copy link
Contributor

christianbrb commented Sep 22, 2020

Description

@taleldayekh Thanks a lot for the implementation of #1941. It improved a lot the usability.

Some in-iteration feedback on the current implementation:

  • 1. The grey text on the notifciation is hard to read. What do you think about switching to white? The date/time could stay grey. CC @sashseurat

  • 2. Sorting of the notifications should be descending (latest on top). It is the other way around.

    grafik

  1. It says "Channel successfully opened" before the deposit has taken place. Is this by design? It might be better to create a new issue with the deposit progress. Would that work and make sense from your perspective?

grafik

Acceptance criteria

Tasks

  • [ ]
@sashseurat
Copy link

  1. The grey text on the notifciation is hard to read. What do you think about switching to white? The date/time could stay grey. CC @sashseurat

How about this color:
#AFB8C0

@christianbrb
Copy link
Contributor Author

@sashseurat #AFB8C0 is a nice color and it would be a new color as far as I can see. Right now I would go with the white we are already using and deciding in a separate issue, if we want to change some or all of this white to #AFB8C0.

@taleldayekh taleldayekh self-assigned this Sep 24, 2020
@taleldayekh taleldayekh removed this from the Product Backlog milestone Sep 24, 2020
@taleldayekh
Copy link
Contributor

It says "Channel successfully opened" before the deposit has taken place.

@christianbrb The deposit is a separate event from the channel open. So the channel open notification is correct in the sense that it displays Channel successfully open before the deposit signing appears in MetaMask. A channel has been opened regardless of whether you choose to deposit or not. If you cancel the MetaMask signature the channel will still be opened.

@christianbrb
Copy link
Contributor Author

Makes sense, that’s why I have opened #2156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants