You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@taleldayekh Thanks a lot for the implementation of #1941. It improved a lot the usability.
Some in-iteration feedback on the current implementation:
1. The grey text on the notifciation is hard to read. What do you think about switching to white? The date/time could stay grey. CC @sashseurat
2. Sorting of the notifications should be descending (latest on top). It is the other way around.
It says "Channel successfully opened" before the deposit has taken place. Is this by design? It might be better to create a new issue with the deposit progress. Would that work and make sense from your perspective?
@sashseurat#AFB8C0 is a nice color and it would be a new color as far as I can see. Right now I would go with the white we are already using and deciding in a separate issue, if we want to change some or all of this white to #AFB8C0.
It says "Channel successfully opened" before the deposit has taken place.
@christianbrb The deposit is a separate event from the channel open. So the channel open notification is correct in the sense that it displays Channel successfully open before the deposit signing appears in MetaMask. A channel has been opened regardless of whether you choose to deposit or not. If you cancel the MetaMask signature the channel will still be opened.
Description
@taleldayekh Thanks a lot for the implementation of #1941. It improved a lot the usability.
Some in-iteration feedback on the current implementation:
1. The grey text on the notifciation is hard to read. What do you think about switching to white? The date/time could stay grey. CC @sashseurat
2. Sorting of the notifications should be descending (latest on top). It is the other way around.
Acceptance criteria
Tasks
The text was updated successfully, but these errors were encountered: