Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphs interface #38

Closed
gdalle opened this issue Nov 3, 2023 · 6 comments
Closed

Graphs interface #38

gdalle opened this issue Nov 3, 2023 · 6 comments

Comments

@gdalle
Copy link
Collaborator

gdalle commented Nov 3, 2023

My intern @olegfafurin and I are trying to formalize the AbstractGraph interface in this repo: https://github.com/gdalle/GraphsInterfaceChecker.jl

We might poke around and find missing stuff in Interfaces.jl

@rafaqz
Copy link
Owner

rafaqz commented Nov 3, 2023

Cool! @olegfafurin please feel free to make issues here for literally any problems you have or missing features you find. That kind of feedback is really useful at this stage.

Note that #37 will change testing and implementation definition a little and #34 will allow (multiple) inheritance soon.

@gdalle
Copy link
Collaborator Author

gdalle commented Jan 3, 2024

The interface is more or less complete for the time being, and the tests have grown larger, in case you're interested to see your package in action @rafaqz

@rafaqz
Copy link
Owner

rafaqz commented Jan 3, 2024

The tests look good! Happy its useful :)

@rafaqz
Copy link
Owner

rafaqz commented Jan 3, 2024

Also nice use of readme as the interface description!

Do you imagine packages will have this as a dependency, or just for checking the interface?

@gdalle
Copy link
Collaborator Author

gdalle commented Jan 3, 2024

For now it's a prototype, still waiting to evolve. Ideally I'd put this in Graphs.jl, but I fear there might be some pushback.

@rafaqz
Copy link
Owner

rafaqz commented Jan 3, 2024

Yes abosolutely. Packages could just have it as a test dependency.

@gdalle gdalle closed this as completed Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants