Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dev recipes for all Links #5775

Closed
Tracked by #2
AaronCrawfis opened this issue Jun 21, 2023 · 1 comment
Closed
Tracked by #2

Add dev recipes for all Links #5775

AaronCrawfis opened this issue Jun 21, 2023 · 1 comment
Labels
triaged This issue has been reviewed and triaged

Comments

@AaronCrawfis
Copy link
Contributor

AaronCrawfis commented Jun 21, 2023 •
edited
Loading

Today we have dev recipes for Redis and Mongo. We need dev recipes for the remainder of the Links:

  • Applications.Link/rabbitMQQueues
  • Applications.Link/sqlDatabases
  • Applications.Link/daprPubSubBrokers
  • Applications.Link/daprSecretStores
  • Applications.Link/daprStateStores

Definition of Done

  • CLI code updated to handle other resource types (today each resource type is hardcoded in the CLI logic)
  • Dev recipe added to the recipes repo under the dev directory

AB#8413
This was referenced Jun 21, 2023
Merged
Merged
Merged
Merged
Merged
AaronCrawfis added a commit that referenced this issue Jun 21, 2023
@AaronCrawfis
Add remaining types to dev recipes processing (#5778)
76f9500 
# Description

Today we have hard-coded support for redis and mongo types for dev
recipes.

This PR adds the remaining types now that they have Recipes support.

## Issue reference

<!--
We strive to have all PR being opened based on an issue, where the
problem or feature have been discussed prior to implementation.
-->

Partially addresses #5775 

## Checklist

Please make sure you've completed the relevant tasks for this PR, out of
the following list:

* [x] Code compiles correctly
* [x] Adds necessary unit tests for change
* [x] Adds necessary E2E tests for change
* [x] Unit tests passing
* [x] Extended the documentation / Created issue for it

## Auto-generated summary

<!--
GitHub Copilot for docs will auto-generate a summary of the PR
-->

<!--
copilot:all
-->
### <samp>🤖 Generated by Copilot at 5af7734</samp>

### Summary
🚀🧪🔗

<!--
1. 🚀 - This emoji represents the addition of new features or
enhancements to the existing functionality of the CLI. The new resource
types for linking applications to external services are examples of new
features that enable users to leverage more dapr capabilities from the
CLI.
2. 🧪 - This emoji represents the addition and modification of test cases
for the `getLinkType` function. The test cases ensure that the function
behaves as expected for different resource types and scenarios. The
emoji also conveys the idea of experimentation and validation of the
code changes.
3. 🔗 - This emoji represents the concept of linking or connecting
applications to external services. The emoji is relevant to the main
purpose of the `getLinkType` function and the linkrp constants. The
emoji also suggests the idea of integration and interoperability between
different systems.
-->
Updated `getLinkType` function and tests to support more resource types
for linking applications. The function now handles dapr, rabbit mq, and
sql resources based on the linkrp constants.

> _To link apps to services with ease_
> _We updated the `getLinkType` function, please_
> _It supports more resource types_
> _Like dapr and rabbit mq bites_
> _And sql databases that store keys_

### Walkthrough
* Add support for more resource types in `getLinkType` function
([link](https://github.com/project-radius/radius/pull/5778/files?diff=unified&w=0#diff-8d95f3c1fe28429c99ace05511baa39ad8209147381755da6007c8781ed17be2L155-R168))
* Update `Test_getLinkType` function to include test cases for new
resource types and modify invalid case
([link](https://github.com/project-radius/radius/pull/5778/files?diff=unified&w=0#diff-c87f030551272551caefea8389b7c31b6159f47554e26f88ca38453234bd92a1R83-R102),
[link](https://github.com/project-radius/radius/pull/5778/files?diff=unified&w=0#diff-c87f030551272551caefea8389b7c31b6159f47554e26f88ca38453234bd92a1L93-R119))
@shalabhms shalabhms added triaged This issue has been reviewed and triaged public-release labels Jun 22, 2023
@vishwahiremat vishwahiremat mentioned this issue Nov 3, 2023
Merged
@willtsai willtsai moved this to 🔖 Prioritized in Radius Roadmap Dec 15, 2023
@willtsai willtsai mentioned this issue Dec 16, 2023
Closed
@AaronCrawfis AaronCrawfis mentioned this issue Jan 2, 2024
Merged
@AaronCrawfis
Copy link
Contributor Author

This is now complete with the completion of radius-project/recipes#52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triaged This issue has been reviewed and triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rynowak @shalabhms @AaronCrawfis