Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make pixscale values robust to non-square pixels #35

Open
e-koch opened this issue May 23, 2022 · 1 comment
Open

Make pixscale values robust to non-square pixels #35

e-koch opened this issue May 23, 2022 · 1 comment

Comments

@e-koch
Copy link
Contributor

e-koch commented May 23, 2022

See astropy/astropy#13268.

We use pixscale = wcs.utils.proj_plane_pixel_scales(cube_hi.wcs.celestial)[0] throughout uvcombine and this poses the risk of not catching non-square pixels.
@e-koch e-koch mentioned this issue May 23, 2022
Merged
5 tasks
@keflavich
Copy link
Contributor

it's such a minor thing here that I don't think we need to do anything about it right now, but I'm tired of using that really long and somewhat easy-to-break pattern

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@keflavich @e-koch