Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS Changes (Which will impact HTML and SCSS) #10

Open
Brockenstein opened this issue Mar 15, 2018 · 0 comments
Open

JS Changes (Which will impact HTML and SCSS) #10

Brockenstein opened this issue Mar 15, 2018 · 0 comments

Comments

@Brockenstein
Copy link
Contributor

After BEM standards have been created we need to make a version two of the JS file.

Goals of the version two: JS file

  1. Fix Activated once misspell
  2. Match Classes to new standards
  3. Possibly remove "video lazy loading" (I am sure there was a plan for this but I don't think this is necessary any longer)

One of the things we might want to consider doing is updating any targeting classes in the JS to have the prefix of "js-" that @dchacon1 presented on.

For example instead of ".make-sticky" the class be ".js-make-sticky" and then I have the question for @dchacon1 would you also add a class to ajd elements like instead of ".ajd_navigation__a" would you add a class called ".js-ajd_navigation__a" ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant