fix: Various improvement and fixes found in 1st test deployment #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skrobul
changed the title
skrobul
force-pushed
the
test-run
branch
2 times, most recently
from
beb9b45 to
1e04196
Compare
|
One more thing I was not sure about - the bootstrap installs the |
cardoe
approved these changes
Feb 22, 2024
This optional environment provides all the necessary tools with just a single command.
otherwise helm misbehaves
…space With the bootstrap/cert-manager/kustomization.yaml we have overriden the namespace of all the resources to be `kube-system`, but the cert-manager still has the annotation `cert-manager.io/inject-ca-from-secret` that refers to the default `cert-manager` namespace. As a result, it is not possible for the cainjector to inject the secret. This patch updates the annotation to use `kube-system` instead.
Prior to this commit, the find command did not work because the '-depth' parameter: - cannot be placed before the name - is a boolean flag that does not accept arguments. I believe the intention was to use `-maxdepth 1` here.
cardoe
approved these changes
Feb 22, 2024
Nope. That file isn't even included in kustomize so we need to just delete it. The ingress actually comes from within the base directory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some of the issues I have found when trying to deploy this on clean cluster.