feat: add component argo workflow #6
Conversation
achatur
force-pushed
the
PUC-133-add-component-argo-workflow
branch
2 times, most recently
from
750fc09 to
d520ad3
Compare
README.md
Outdated
| ### Setup Argo Workflow | ||
|
|
||
| ```bash | ||
| kubectl kustomize --enable-helm components/11-argo-workflow/ | kubectl apply --server-side -f - |
There was a problem hiding this comment.
So here you say it needs server side apply but then the ArgoCD config isn't using server side apply. Which is it?
There was a problem hiding this comment.
You also shouldn't need to add this to the top level readme since Argo should deploy this automatically.
There was a problem hiding this comment.
I was wondering that. OK I'll remove this
| --- | ||
|
|
||
| apiVersion: kind.x-k8s.io/v1alpha4 | ||
| kind: Cluster |
There was a problem hiding this comment.
This whole config file assumes that you're running on kind and will fail in any other cluster.
There was a problem hiding this comment.
hmm.. so I am thinking overlay w/ dev vs prod. Would that work? This can remain a template
| helm.sh/chart: argo-workflows-0.40.10 | ||
| app.kubernetes.io/instance: argo | ||
| app.kubernetes.io/managed-by: Helm | ||
| app.kubernetes.io/version: "0.40.10" |
There was a problem hiding this comment.
The hardcoded versions here will break in the future. But what's the point of the ConfigMap? it's empty?
There was a problem hiding this comment.
there is no point.. it was a place holder but I can remove it
| valuesFile: values.yaml | ||
| releaseName: argo-workflow | ||
| version: 0.40.10 | ||
| repo: https://argoproj.github.io/argo-helm |
There was a problem hiding this comment.
Given what the project says about the charts being community maintained and not officially maintained. The fact that the kustomize native config is the officially maintained config. We also want to install this in the namespaced form and not cluster wide which the charts don't support. I think we switch.
achatur
force-pushed
the
PUC-133-add-component-argo-workflow
branch
2 times, most recently
from
74bc8c4 to
50ef5d7
Compare
We need to add Argo Workflows as a component. This adds it via a kustomize template.
cardoe
force-pushed
the
PUC-133-add-component-argo-workflow
branch
from
50ef5d7 to
9238f09
Compare
cardoe
changed the title
Adds argo-workflow as a component. This is not adding events or the workflows yet. It's just setting up the workflow namespace and environment to be used. New workflow namespace is configured as "argo".