Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixes casing for UnderStack in docs #491

Merged
merged 1 commit into from
Nov 18, 2024
Merged

fix: fixes casing for UnderStack in docs #491

merged 1 commit into from
Nov 18, 2024

Conversation

nicholaskuechler
Copy link
Contributor

@nicholaskuechler nicholaskuechler commented Nov 18, 2024 •
edited
Loading

I also noticed we were pinning the mkdocs github actions to very old versions from March 2024. I've unpinned them.

@nicholaskuechler nicholaskuechler changed the title chore: test building and deploying docs fix: fixes casing for UnderStack in docs Nov 18, 2024
@nicholaskuechler nicholaskuechler marked this pull request as ready for review November 18, 2024 18:46
cardoe
cardoe requested changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@cardoe cardoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skrobul I enabled the container pinning after you had asked for that. If you want to move the version up, you need to switch to like v4.3.0 instead of v4. The bot will pin stuff right back.

@nicholaskuechler
Copy link
Contributor Author

@skrobul I enabled the container pinning after you had asked for that. If you want to move the version up, you need to switch to like v4.3.0 instead of v4. The bot will pin stuff right back.

I've already removed unpinning them.

@skrobul
Copy link
Collaborator

skrobul commented Nov 18, 2024

The bot will pin stuff right back.

I was hoping it would pin stuff back to whatever commit the v4 points to today, is that not how it works?

cardoe
cardoe requested changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@cardoe cardoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove my block.

@cardoe
Copy link
Contributor

cardoe commented Nov 18, 2024

The bot will pin stuff right back.

I was hoping it would pin stuff back to whatever commit the v4 points to today, is that not how it works?

Maybe.

cardoe
cardoe reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

@cardoe cardoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing my blocker.

cardoe
cardoe approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@cardoe cardoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently I can only approve to remove the blocker.

@cardoe cardoe added this pull request to the merge queue Nov 18, 2024
Merged via the queue into main with commit f7ae039 Nov 18, 2024
16 checks passed
@cardoe cardoe deleted the docs-test-20241118-1 branch November 18, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skrobul skrobul skrobul approved these changes

@cardoe cardoe cardoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicholaskuechler @skrobul @cardoe