Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: retire unused container #485

Merged
merged 2 commits into from
Nov 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions .github/workflows/build-container-images.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ on:
workflow_dispatch:
pull_request:
paths:
- "containers/argo_utils/**"
- "containers/bmc-utils/**"
- "containers/python311_alpine/**"
- "containers/python312_alpine/**"
Expand Down Expand Up @@ -69,17 +68,6 @@ jobs:
labels: |
org.opencontainers.image.version=${{ env.VERSION_PYTHON312 }}

- name: Build and deploy Argo Utils image
uses: docker/build-push-action@4f58ea79222b3b9dc2c8bbdd6debcef730109a75 # v6
with:
context: containers/argo_utils/
file: containers/argo_utils/Dockerfile.argo_utils
# push for all main branch commits
push: ${{ github.event_name != 'pull_request' }}
tags: ghcr.io/${{ github.repository }}/argo-utils-python3.11.8:latest,ghcr.io/${{ github.repository }}/argo-utils-python3.11.8:${{ env.VERSION_ARGO_UTILS }}
labels: |
org.opencontainers.image.version=${{ env.VERSION_ARGO_UTILS }}

- name: Build and deploy BMC Utils image
uses: docker/build-push-action@4f58ea79222b3b9dc2c8bbdd6debcef730109a75 # v6
with:
Expand Down
25 changes: 0 additions & 25 deletions containers/argo_utils/Dockerfile.argo_utils

This file was deleted.

61 changes: 0 additions & 61 deletions containers/argo_utils/README.md

This file was deleted.

40 changes: 0 additions & 40 deletions containers/argo_utils/code/argo_python/README.md

This file was deleted.

73 changes: 0 additions & 73 deletions containers/argo_utils/code/argo_python/__init__.py

This file was deleted.

15 changes: 0 additions & 15 deletions docs/component-argo-workflows.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,20 +39,6 @@ Authorization is handled by Kubernetes' RBAC services. Workflows are run with th
Account. We've provided the `workflow` Service Account, which has been granted access to the necessary Kubernetes
resources, to run the provided WorkflowTemplates.

### argo-python

To facilitate the ability to pass data securely between Workflows the [argo-python][argo-python] Class was written.
This Python Class writes Kubernetes Secrets directly to the Kubernetes API from the Workflow's Pod, allowing these
Secrets to be securely mounted into a subsequent Workflow's environment.

By default these Secrets are created with an ownerReference set to the Workflow which created them, which allows
them to be garbage collected when that Workflow is terminated. The ownerReference requires details about the
Workflow to be passed in. This is available in the Workflow from the
[workflow variable](https://argo-workflows.readthedocs.io/en/latest/variables/#global).

An example WorkflowTemplate demonstrating argo-python usage can be found
[here](https://github.com/rackerlabs/understack/blob/main/workflows/argo-events/workflowtemplates/get-bmc-creds.yaml).

### Argo CLI

Argo Workflows has a CLI and the installation instructions can be found [here](https://github.com/argoproj/argo-workflows/releases/).
Expand Down Expand Up @@ -98,4 +84,3 @@ STEP TEMPLATE PODNAME DURATION MESSAGE

[argo-workflows]: <https://argo-workflows.readthedocs.io/en/latest/>
[argo-events]: <https://argoproj.github.io/argo-events/>
[argo-python]: <https://github.com/rackerlabs/understack/tree/main/argo-workflows/generic/code/argo_python>
1 change: 0 additions & 1 deletion workflows/argo-events/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ resources:
- serviceaccounts/openstack-sensor-submit-workflow.yaml
- workflowtemplates/nautobot-api.yaml
- workflowtemplates/sync-provision-state-to-nautobot.yaml
- workflowtemplates/node-events.yaml
- workflowtemplates/undersync-device.yaml
- workflowtemplates/undersync-switch.yaml
- workflowtemplates/keystone-event-project.yaml
Expand Down
54 changes: 0 additions & 54 deletions workflows/argo-events/workflowtemplates/node-events.yaml

This file was deleted.