chore: flips the deploy paths and rename for clarity #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bring the files for a specific cluster closer together by having them live in a top level that follows the name of the deployment.
The ref name secrets wasn't good because a lot of times this is where we are getting a helm values file from so rename it to 'deploy' to be more clear.
A lot of the things we are storing now days are just Kubernetes manifests and not just secrets so rename this path to make it more clear what belongs here.
skrobul
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flipped the paths in the deploy repo so that the name of the deployment is at the top-level. Renamed secrets to manifests since there is more in there than secrets and folks have complained. Renamed the reference to the deploy repo to deploy from secrets.