fix: Hacking on ironic component #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholaskuechler
changed the title
cardoe
force-pushed
the
ironic
branch
7 times, most recently
from
9ebdf98 to
3cf8831
Compare
skrobul
reviewed
Feb 27, 2024
Comment on lines
+3
to
+8
| So unfortunately OpenStack Helm doesn't publish helm charts that can be consumed like | ||
| regular helm charts. You must instead clone two of their git repos side by side and | ||
| build the dependencies manually. They additionally don't split out secrets but instead | ||
| template them into giant config files or even executable scripts that then get stored | ||
| as secrets, a clear violation of <https://12factor.net>. As a result we cannot store | ||
| a declarative config of Keystone and allow users to supply their own secrets. |
There was a problem hiding this comment.
Is it just because they don't publish them in a repo? If so, could we just host it ourselves internally?
There was a problem hiding this comment.
That's certainly an option. I'm happy to get some ideas around it.
| table: "*" | ||
| username: ironic | ||
| grantOption: true | ||
| host: "%" |
There was a problem hiding this comment.
should we restrict this to pod networking subnet?
There was a problem hiding this comment.
Yeah that would make sense. No idea how to look that up.
There was a problem hiding this comment.
kubectl get nodes -o jsonpath='{.items[*].spec.podCIDR}'
would be one way, but it's also subject to change so maybe just 10.x.x.x would make sense
|
Closing this out in favor of #11 which integrates all of these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My changes to get it to progress the deployment. The ironic-api starts, but ironic-conductor fails to start: