-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat (pop api): add native token to local fungibles use case #97
Comments
About the open questions:The discussion related to the design of the returned error can be referenced from this: paritytech/polkadot-sdk#2240 From my perspective, adding If there can be better implementation to cover the case without adding extra dispatches, then adding |
Thanks for looking into this. Lets keep it as simple as possible for now. |
Maybe a little late for this comment. But why do we need the API to support native balance transfers from ink! supports this by default: https://github.com/use-ink/ink-examples/blob/main/contract-transfer/lib.rs#L35 |
@peterwht We want the users only need to care about using pop-api for interacting with the runtime and local fungible is more than just |
The fungibles use case allows a contract to interact with tokens on Pop Network. As of now this is only possible with tokens in pallet assets. The native token (pallet balances) should be included. First check whether this has any blockers with the current functions, also look at #104, #98 & #92. This should be implemented with #113 in mind as final implementation of the pop api.
Open Questions:
InsufficientBalance
. When there is no balance to pay for fees or create an asset, which requires a deposit, the balances pallet also returnInsufficientBalance
. Right now this is changed toNoBalance
because there needs to be a separation for good developer experience. However,NoBalance
will also be returned when there are not enough tokens for a requestedtransfer
with the native token. Do we need to add an errorNoFees
andNoBalance
?The text was updated successfully, but these errors were encountered: