Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use proper #[arg] in all the clap arguments #353

Open
AlexD10S opened this issue Nov 27, 2024 · 0 comments
Open

refactor: use proper #[arg] in all the clap arguments #353

AlexD10S opened this issue Nov 27, 2024 · 0 comments
Labels
good first issue Good for newcomers refactor Refactor of code

Comments

@AlexD10S
Copy link
Collaborator

AlexD10S commented Nov 27, 2024

In the code, we currently use both #[arg] and #[clap] to define arguments, for example:

        #[arg(short = 'o', long = "output")]
	pub(crate) output_file: Option<PathBuf>,
	/// For production, always build in release mode to exclude debug features.
	#[clap(short = 'r', long, default_value = "true")]
	pub(crate) release: bool, 

In https://github.com/r0gue-io/pop-cli/blob/main/crates/pop-cli/src/commands/build/spec.rs#L135C2-L139C27

Review all commands and update the argument definitions to consistently use #[arg], as it aligns with the examples provided in the clap library documentation: https://github.com/clap-rs/clap

@AlexD10S AlexD10S added good first issue Good for newcomers refactor Refactor of code labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers refactor Refactor of code
Projects
None yet
Development

No branches or pull requests

1 participant