-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building "collapse" package for use with webr in jupyterlite webr kernel #9
Comments
The no_parallel_simd branch is something else, having to do with OpenMP. The parallel package is part of base R now and should be included in any R distribution. I only conditionally use the mclapply() function from it. Please try the following: remove the import line in the NAMESPACE and replace all instances of mclappy with parallel::mclapply. If that works I can change the code towards this end. |
Thanks, will give that a try. Updates made, but I'm obviously doing something elementarily wrong in trying to build the package! I need to take a break from this for a while because I'm just not seeing it?! |
I am not sure why In any case there are some bigger issues here. @SebKrantz is correct, the parallel package should be available as part of the webR distribution. You should be able to run This indicates to me that your base webR distribution is corrupt in some way. IIRC you are using your own Once that is working, you should be able to load the A bigger problem is that I notice that separately to this you are trying to compile the The curl package relies on the system dependency The only real way forward is to create a "shim" curl package or system library that replaces HTTP curl requests with JavaScript browser API calls. This is something we're planning on looking at at some point in the future, but the project will be a large undertaking. Curl has a wide API and supports many network protocols, and so it is not entirely clear which subset of curl APIs can be translated into browser APIs, not to speak about actually implementing them. |
@georgestagg yes, the curl was in there as a leftover (trying to get all the dependencies / imports for all the packages that are used in notebooks in the distribution ( Re: the Re: the custom path: ah, |
|
Interesting, I believe that should work even if the work is not actually required here. It would be interesting to know if the original |
@georgestagg Yes, the others work fine ( |
I've been stuck on this for a couple of hours now, and don't see what I'm doing wrong?
I'm trying to use the
plm
package, which has a dependencycollapse
which pulls in an item in itsNAMESPACE
file fromparallel
, which is understandably not in the corewebr
package. The function that is loaded fromparallel
is guarded by a parallel= flag with a defaultFALSE
, so I assume that commenting out theNAMESPACE
item in the package shouldn't have a side effect if R doesn't statically check that all functions are declared.I tried downloading the
collapse
package source, commenting the unwanted import out, tarring the package and then attempting to compile it using the webr package builder action, but couldn't find a way of naming the local file that didn't cause an error when using the package builder action.I (mistakenly) noticed an issue on the
collapse
repo (SebKrantz/collapse#550) pointing to what I mistook for a non-parallel branch, and thought to try to import src file using the package stringgithub::SebKrantz/collapse@no_parallel_simd
. The build job runs but thecollapse
package is not built.So what am I doing wrong, in the two respects of:
The text was updated successfully, but these errors were encountered: