Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New vignette on subgraphs and poly2nb snap #168

Open
rsbivand opened this issue Sep 7, 2024 · 5 comments
Open

New vignette on subgraphs and poly2nb snap #168

rsbivand opened this issue Sep 7, 2024 · 5 comments

Comments

@rsbivand
Copy link
Member

rsbivand commented Sep 7, 2024

@JosiahParry I'd be grateful for a view on https://r-spatial.github.io/spdep/articles/subgraphs.html, and agreement to use the Tokyo geometries in that vignette.

@JosiahParry
Copy link
Contributor

Thanks @rsbivand! I'll give it a read.

Let me run the data question by my colleague quickly as she provided it to me!

@rsbivand
Copy link
Member Author

rsbivand commented Sep 7, 2024

Thanks! I removed all the columns from the Tokyo data set apart from the ID column and the geometries, If need be, your colleague could tell us where the geometries came fropm and we could reconstruct them from that source, but maybe the divergences would vanish then.

@JosiahParry
Copy link
Contributor

https://sgsup.asu.edu/sparc/multiscale-gwr

It turns out it is a test dataset from ASU’s MGWR docs

@rsbivand
Copy link
Member Author

rsbivand commented Sep 8, 2024

I've emailed Tomoki Nakaya to ask; GWmodel of which he is an author does not bundle this dataset. Maybe the gaps came from projection on a 32-bit platform - they were more common 20 years ago, and the data set was used for a 2005 Poisson GWR article.

@JosiahParry
Copy link
Contributor

I forgot to give comments on this. I read it and it was very well done!

I would only ask that you strongly emphasize

The ripples in one pond cannot cross into a separate pond if they are not connected.

Either bold or a block quote or something. This is the most important take away from the vignette and it is so eloquently stated. The rest is how to address or handle it using spdep.

rsbivand added a commit that referenced this issue Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants