Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with reduced dependency fallout #208

Closed
22 tasks done
hadley opened this issue Nov 6, 2024 · 2 comments
Closed
22 tasks done

Deal with reduced dependency fallout #208

hadley opened this issue Nov 6, 2024 · 2 comments

Comments

@hadley
Copy link
Member

hadley commented Nov 6, 2024

expect_vector():

Not on GitHub:

@olivroy unfortunately #196 ended up breaking a bunch of packages on CRAN because they used vctrs or tibble and got them implicitly via testthat + waldo. AND unfortunatley our revdepcheck server didn't set the right env var to pick this up 😞

hadley added a commit that referenced this issue Nov 6, 2024
A couple of packages (including httr2) use a hacky wrapper to avoid taking a dependency on bit64.

Part of #208
@olivroy
Copy link
Contributor

olivroy commented Nov 6, 2024

I was afraid this could happen, but was surprised that the revdep check didn't catch it...

hadley added a commit that referenced this issue Nov 6, 2024
A couple of packages (including httr2) use a hacky wrapper to avoid taking a dependency on bit64.

Part of #208
@hadley
Copy link
Member Author

hadley commented Nov 6, 2024

Message I'm copying and pasting:

Unfortunately the recent waldo release broke your package on CRAN because it no longer imports tibble, and your package was implicitly depending on it. The easiest fix is to just make the dependency explicit.

Apologies for not discovering this before CRAN release, but we had a buglet in the code that runs our revdep checks 🙁.

@hadley hadley closed this as completed Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants