Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest dependency on tibble ? #2079

Closed
jeroen opened this issue Nov 5, 2024 · 4 comments · Fixed by #2080
Closed

Suggest dependency on tibble ? #2079

jeroen opened this issue Nov 5, 2024 · 4 comments · Fixed by #2080

Comments

@jeroen
Copy link
Member

jeroen commented Nov 5, 2024

usethis errors in a revdep-check from CRAN :

> Package: usethis
> Check: tests
> New result: ERROR
>     Running ‘spelling.R’ [0s/0s]
>     Running ‘testthat.R’ [73s/41s]
>   Running the tests in ‘tests/testthat.R’ failed.
>   Complete output:
>     > library(testthat)
>     > library(usethis)
>     >
>     > test_check("usethis")
>     Starting 2 test processes
>     [ FAIL 2 | WARN 174 | SKIP 154 | PASS 617 ]
>
>     ══ Skipped tests (154) ═════════════════════════════════════════════════════════
>     • No Git user configured (26): 'test-github-actions.R:2:3',
>       'test-github-actions.R:29:3', 'test-github-actions.R:45:3',
>       'test-github-actions.R:60:3', 'test-github-actions.R:90:3',
>       'test-github-actions.R:117:3', 'test-release.R:163:3',
>       'test-release.R:177:3', 'test-release.R:200:3', 'test-badge.R:18:3',
>       'test-ci.R:2:3', 'test-git.R:2:3', 'test-git.R:23:3', 'test-git.R:41:3',
>       'test-git.R:52:3', 'test-git.R:78:3', 'test-edit.R:46:3',
>       'test-edit.R:117:3', 'test-github.R:2:3', 'test-github.R:16:3',
>       'test-github.R:35:3', 'test-readme.R:16:3', 'test-tidyverse.R:60:3',
>       'test-tidyverse.R:74:3', 'test-upkeep.R:17:3', 'test-utils-git.R:3:3'
>     • Not on GitHub Actions, Travis, or Appveyor (1): 'test-edit.R:67:3'
>     • On CRAN (127): 'test-github-actions.R:25:3', 'test-github-actions.R:82:3',
>       'test-author.R:51:3', 'test-author.R:68:3', 'test-author.R:83:3',
>       'test-release.R:9:3', 'test-release.R:55:3', 'test-release.R:84:3',
>       'test-release.R:91:3', 'test-badge.R:10:3', 'test-badge.R:26:3',
>       'test-course.R:17:3', 'test-course.R:64:3', 'test-course.R:241:3',
>       'test-course.R:289:3', 'test-coverage.R:4:3', 'test-cpp11.R:40:3',
>       'test-browse.R:78:3', 'test-browse.R:90:3', 'test-data-table.R:16:3',
>       'test-data-table.R:30:3', 'test-git-default-branch.R:2:3',
>       'test-git-default-branch.R:37:3', 'test-git-default-branch.R:55:3',
>       'test-git-default-branch.R:76:3', 'test-latest-dependencies.R:2:3',
>       'test-latest-dependencies.R:18:3', 'test-latest-dependencies.R:30:3',
>       'test-helpers.R:35:3', 'test-helpers.R:45:3', 'test-helpers.R:63:3',
>       'test-helpers.R:76:3', 'test-helpers.R:89:3', 'test-helpers.R:105:3',
>       'test-helpers.R:117:3', 'test-lifecycle.R:6:3', 'test-logo.R:18:3',
>       'test-logo.R:30:3', 'test-news.R:7:3', 'test-news.R:20:3',
>       'test-news.R:32:3', 'test-package.R:10:3', 'test-package.R:20:3',
>       'test-package.R:34:3', 'test-pipe.R:19:3', 'test-proj-desc.R:5:3',
>       'test-proj-desc.R:19:3', 'test-pkgdown.R:13:3', 'test-pkgdown.R:59:3',
>       'test-proj.R:39:3', 'test-proj.R:57:3', 'test-r.R:16:3', 'test-r.R:41:3',
>       'test-r.R:49:3', 'test-r.R:59:3', 'test-r.R:63:3', 'test-readme.R:31:3',
>       'test-readme.R:41:3', 'test-readme.R:50:3', 'test-readme.R:60:3',
>       'test-rename-files.R:28:3', 'test-roxygen.R:5:3', 'test-tibble.R:15:3',
>       'test-rstudio.R:37:3', 'test-tutorial.R:5:3', 'test-ui-legacy.R:5:3',
>       'test-tidyverse.R:16:3', 'test-use_import_from.R:22:3', 'test-upkeep.R:13:3',
>       'test-usethis-deprecated.R:5:3', 'test-use_standalone.R:2:3',
>       'test-use_standalone.R:33:3', 'test-use_standalone.R:50:3',
>       'test-use_standalone.R:66:3', 'test-use_standalone.R:115:3',
>       'test-use_standalone.R:123:3', 'test-utils-github.R:121:3',
>       'test-utils-github.R:162:3', 'test-utils-github.R:166:2',
>       'test-utils-github.R:170:2', 'test-utils-github.R:174:2',
>       'test-utils-github.R:178:2', 'test-utils-github.R:182:2',
>       'test-utils-github.R:186:2', 'test-utils-github.R:190:2',
>       'test-utils-github.R:194:2', 'test-utils-github.R:198:2',
>       'test-utils-github.R:224:3', 'test-utils-github.R:228:3',
>       'test-utils-github.R:235:3', 'test-utils.R:9:3', 'test-utils-ui.R:5:3',
>       'test-utils-ui.R:5:3', 'test-utils-ui.R:5:3', 'test-utils-ui.R:5:3',
>       'test-utils-ui.R:50:3', 'test-utils-ui.R:50:3', 'test-utils-ui.R:50:3',
>       'test-utils-ui.R:50:3', 'test-utils-ui.R:84:3', 'test-utils-ui.R:88:3',
>       'test-utils-ui.R:92:3', 'test-utils-ui.R:106:3', 'test-utils-ui.R:106:3',
>       'test-utils-ui.R:119:3', 'test-utils-ui.R:119:3', 'test-utils-ui.R:133:3',
>       'test-utils-ui.R:133:3', 'test-utils-ui.R:144:3', 'test-utils-ui.R:144:3',
>       'test-utils-ui.R:151:3', 'test-utils-ui.R:151:3', 'test-utils-ui.R:165:3',
>       'test-utils-ui.R:184:3', 'test-utils-ui.R:184:3', 'test-utils-ui.R:191:3',
>       'test-utils-ui.R:191:3', 'test-utils-ui.R:202:3', 'test-utils-ui.R:202:3',
>       'test-utils-ui.R:214:3', 'test-utils-ui.R:214:3', 'test-vignette.R:12:3',
>       'test-version.R:16:3', 'test-version.R:32:3', 'test-version.R:59:3',
>       'test-version.R:82:3', 'test-write.R:250:3'
>
>     ══ Failed tests ════════════════════════════════════════════════════════════════
>     ── Error ('test-use_import_from.R:4:3'): use_import_from() imports the related package & adds line to package doc ──
>     <rlib_error_package_not_found/rlang_error/error/condition>
>     Error in `use_import_from("tibble", "tibble")`: The package "tibble" is required.
>     Backtrace:
>         ▆
>      1. └─usethis::use_import_from("tibble", "tibble") at test-use_import_from.R:4:3
>      2.   └─rlang::check_installed(package)
>     ── Error ('test-use_import_from.R:13:3'): use_import_from() adds one line for each function ──
>     <rlib_error_package_not_found/rlang_error/error/condition>
>     Error in `use_import_from("tibble", c("tibble", "enframe", "deframe"))`: The package "tibble" is required.
>     Backtrace:
>         ▆
>      1. └─usethis::use_import_from("tibble", c("tibble", "enframe", "deframe")) at test-use_import_from.R:13:3
>      2.   └─rlang::check_installed(package)
>
>     [ FAIL 2 | WARN 174 | SKIP 154 | PASS 617 ]
>     Error: Test failures
>     Execution halted
@jennybc
Copy link
Member

jennybc commented Nov 5, 2024

Thanks for the heads up!

No, this probably means that some test has crept in that needs to be fixed. This is a perennial problem in usethis, where it places infrastructure for packages that it does not, itself, depend on. A constant battle.

@olivroy
Copy link
Contributor

olivroy commented Nov 6, 2024

FYI this happens because waldo 0.6.0 (and therefore testthat) no longer imports tibble. r-lib/waldo#196

@jennybc
Copy link
Member

jennybc commented Nov 6, 2024

This is what #2080 is about presumably.

@jeroen
Copy link
Member Author

jeroen commented Nov 6, 2024

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants