Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update behavior when total = Inf to be same as NA #722

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Update behavior when total = Inf to be same as NA #722

merged 2 commits into from
Aug 28, 2024

Conversation

LouisMPenrod
Copy link
Contributor

Add test to check same behavior between NA and Inf
Update NEWS
Fixes #630

@LouisMPenrod
Use same behavior in cli_progress_bar when total = Inf as when total …
f09d5c0 
…= NA

Add test to check same behavior
Update NEWS
Fixes r-lib#630
@gaborcsardi
Copy link
Member

Great, thank you!

@gaborcsardi gaborcsardi merged commit e55ae2c into r-lib:main Aug 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Progress bar should handle total = Inf better
2 participants
@LouisMPenrod @gaborcsardi