Handle non finite edge cases with pluralization() #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krlmlr
reviewed
Aug 15, 2024
Co-authored-by: Kirill Müller <[email protected]>
|
Looks great, it is exactly the solution I had in mind. :D Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft resolution to #701 and some related edge cases. The issue seems to be more general than originally described with handling any of the non-finite values (including NAs).
The currently implemented behavior is the following:
Numeric non-finite values (
NA_real_,NA_integer_,NaN,Infand-Inf) will be treated as aqty> 1 for pluralization purposes.Non-numeric NA values (
NA_character_andNA) are treated as a non-numeric input soqtyis based on the vector's length.I've opted not to throw an error for numeric
NAs orNaNcases since that seemed a bit severe but it also seems like a plausible outcome and happy to switch to that behavior if that is a better option.